feat(weave): add timestamp override support for retroactive call logging #5855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=529ad27de5a1fd2f560a597e9bf06322f7920e7b |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
looks good, can you please add a test |
tssweeney
approved these changes
Dec 17, 2025
Add test coverage for the new started_at and ended_at timestamp parameters in log_call, create_call, and finish_call. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove unused sys and warnings imports from weave/__init__.py - Fix line length formatting in test files - Fix typo "withoug" -> "without" in environment.py - Add "gauge" to typos allowlist (correct spelling) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
vanpelt
added
the
merge-post-freeze-12-25
Contributor
|
❌ Documentation Reference Check Failed No documentation reference found in the PR description. Please add either:
This check is required for all PRs except those that start with "chore(weave)" or explicitly state "docs are not required". Please update your PR description and this check will run again automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The claude session logger I made for hack week allows users to import historic claude sessions. The UI looks much better if the start and end times of the calls reflect what they were when that claude session ran. We need to consider if doing this will mess with data locality and our special time ordered uuids.
Testing
How was this PR tested?