fix(weave): Special-casing google.genai module patching #5879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutralino1
added
the
merge-post-freeze-12-25
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=6afccb63dc5d7b6fa5e556b1f77e0f39d62451ab |
Contributor
|
❌ Documentation Reference Check Failed No documentation reference found in the PR description. Please add either:
This check is required for all PRs except those that start with "chore(weave)" or explicitly state "docs are not required". Please update your PR description and this check will run again automatically. |
neutralino1
commented
Dec 30, 2025
Comment on lines
+319
to
+322
| if fullname.startswith("google.genai"): | ||
| root_module = "google.genai" | ||
| else: | ||
| root_module = fullname.split(".")[0] |
Collaborator
Author
There was a problem hiding this comment.
This is ugly, any better ideas?
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
adrnswanberg
approved these changes
Dec 30, 2025
gtarpenning
approved these changes
Dec 30, 2025
Collaborator
|
@neutralino1 this fix works because you're using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addressed the bug reported in #5844. The
google.genaimodule is not being autopatched because it is a namespaced module.This PR special-cases this module.
Testing
How was this PR tested?