chore(weave): API for querying queue items #5882
Open
+1,028
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
chance-wnb
force-pushed
the
chance/queue_items_fetch_api
branch
from
725b081 to
f302043
Compare
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2af49d5e5767ee703929e018a11c92f37ef72dd4 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
chance-wnb
force-pushed
the
chance/queue_stats_api
branch
from
a2cb043 to
275496b
Compare
chance-wnb
force-pushed
the
chance/queue_items_fetch_api
branch
from
f302043 to
c19fe59
Compare
chance-wnb
force-pushed
the
chance/queue_items_fetch_api
branch
from
c19fe59 to
89686a9
Compare
neutralino1
added
the
merge-post-freeze-12-25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Annotation Queue Items Query API
This PR adds backend and frontend support for querying annotation queue items with pagination and sorting capabilities.
Backend Changes
New API Endpoint:
annotation_queue_items_queryType Definitions
AnnotationQueueItemsQueryReqandAnnotationQueueItemsQueryResto trace server interfaceAnnotationQueueItemSchemato include all necessary fields for displaying queue itemsQuery Builder (
annotation_queues_query_builder.py)make_queue_items_queryfunction with support for:call_started_at,call_op_name,created_at,updated_atORDER BY created_at ASC, id ASCas default to ensure stable pagination when multiple items have identical timestampsImplementation Across Trace Server Layers
clickhouse_trace_server_batched.py- Main ClickHouse implementationexternal_to_internal_trace_server_adapter.py- ID conversion adapter layercaching_middleware_trace_server.py- Passthrough caching middlewareremote_http_trace_server.py- HTTP client implementationSchema Cleanup
added_atfield: Eliminated redundant timestamp field, usingcreated_atinsteadTesting
New Test Coverage
test_annotation_queue_items_query_basic- Basic query functionalitytest_annotation_queue_items_query_with_pagination- Pagination with limit/offsettest_annotation_queue_items_query_with_sorting- Custom sort orderstest_annotation_queue_items_query_empty_queue- Empty queue edge casetest_annotation_queue_items_query_with_multiple_sort_fields- Multi-field sortingRelated Work
This PR builds on the annotation queues feature introduced in earlier commits and prepares the foundation for the upcoming annotation review interface where users will interact with queued calls to provide feedback and annotations.