Rename todoApp to kitchen-sink and move it to examples/ dir
#3197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying wasp-docs-on-main with
|
| Latest commit: |
8c08815
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffe9e5ee.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://franjo-todoapp-renaming.wasp-docs-on-main.pages.dev |
FranjoMindek
temporarily deployed
to
examples/waspleau-production
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
examples/websockets-realtime-voting-production
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
examples/waspello-production
GitHub Actions
Inactive
|
Nice stuff! I will let @infomiho approve since he knows this part better, but I support the change, and PR description sounds reasonable to me, so soft approve from me :D. |
infomiho
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
I think it makes sense and the changes look OK to me.
I'd say we are blocked by:
This will currently make it so we don't run kitchen-sink tests on each PR.
I'd merge this only AFTER we implement the change that will run example apps tests on each PR, so we are not in a limbo with PRs that are not running tests on the kitchen-sink app.
Let me know if you need help with generating any of the production API keys for the kitchen sink app.
# Conflicts: # .github/workflows/ci-examples-test.yaml # .github/workflows/release-examples-deploy.yaml # waspc/ChangeLog.md # waspc/examples/todoApp/README.md # waspc/run
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Failure
# Conflicts: # .github/workflows/ci-deploy-test.yaml
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Failure
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3085
The goal is to make
todoAppmore public and accessible to users.For that reason we are renaming it to
kitchen-sinkand moving it toexamples/(fromwaspc/examples/) dir.As such
kitchen-sinkbecomes one of our example apps and will be treated so.To go along with that, we are moving
kitchen-sinktests fromwaspc-ci.yamlworkflow toexamples-e2e-tests.yaml.Additionally, we are adding it as one of the
deploy-examples.ymloptions.NOTE:
This will currently make it so we don't run
kitchen-sinktests on each PR.HOWEVER, in our release post mortem we did declare that we will want to run
examples-e2e-tests.yaml(along with other test worklows) on each PR. So when we do removepathsfrom their PR triggers, this will go back to old behavior of runningkitchen-sinktests on each PR.In this PR I also:
kitchen-sink'sREADME.mdensure_app_compiles_and_builds.shscriptwasp build+tscrunscripttest:examplesnow includeskitchen-sinktest:kitchen-sinknpx playwright install --with-depstoplaywrightbased tests to make sure we have all the deps installedSidenote: It's really hard to check if I covered all
todoApprenames since our tutorial apps are also calledtodoApp. It's good that we are renaming because confusion.TODO: Generate
kitchen-sinkproduction API keys.