-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Waspc e2e-tests container tests #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying wasp-docs-on-main with
|
| Latest commit: |
e7910b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c0e5b8d.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://franjo-container-tests.wasp-docs-on-main.pages.dev |
# Conflicts: # waspc/e2e-tests/SnapshotTest/snapshots/kitchen-sink-golden/wasp-app/.wasp/out/server/.npmrc # waspc/e2e-tests/SnapshotTest/snapshots/kitchen-sink-golden/wasp-app/.wasp/out/web-app/.npmrc # waspc/e2e-tests/SnapshotTest/snapshots/wasp-compile-golden/wasp-app/.wasp/out/server/.npmrc # waspc/e2e-tests/SnapshotTest/snapshots/wasp-compile-golden/wasp-app/.wasp/out/web-app/.npmrc # waspc/e2e-tests/SnapshotTest/snapshots/wasp-migrate-golden/wasp-app/.wasp/out/server/.npmrc # waspc/e2e-tests/SnapshotTest/snapshots/wasp-migrate-golden/wasp-app/.wasp/out/web-app/.npmrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of Wasp CLI we ship commands which can affect the host OS.
To run these commands in a safe manner, I've decided to create
ContainerTestconcept which executes commands in isolated containers.These are: install (actually outside of CLI), uninstall, completions and telemetry.
What I want to avoid is having to build
wasp-clibinary inside of the container because that takes long.For that reason these tests are currently skipped on the macOS, because it's binary can't be run inside of the container.
Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects
waspc, make sure you satisfy the following:ChangeLog.mdwith description of the change this PR introduces.waspcversion inwaspc.cabalto reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.Add a regression test if needed
If you did a bug fix, make sure you satisfy the following:
If you're unable to add a regression test, please explain why.
This likely indicates that our current testing setup needs improvement.
Test Coverage
Please ensure your changes are adequately tested:
If you're unable to add tests or if coverage is partial, please explain why below:
Update example apps if needed
If you did code changes and added a new feature, make sure you satisfy the following:
waspc/examples/todoAppand its e2e tests as needed and manually checked it works correctly.If you did code changes and updated an existing feature, make sure you satisfy the following:
waspc/examples/todoAppand its e2e tests as needed and manually checked it works correctly.Update starter apps if needed
If you did code changes and updated an existing feature, make sure you satisfy the following:
basicstarter as needed and manually checked it works correctly.todo-tsstarter as needed and manually checked it works correctly.embeddingsstarter as needed and manually checked it works correctly.saasstarter as needed and manually checked it works correctly.Update e2e tests if needed
If you did code changes and changed Wasp's code generation logic, make sure you satisfy the following: