Skip to content

Conversation

@FranjoMindek
Copy link
Contributor

@FranjoMindek FranjoMindek commented Oct 15, 2025

Description

As part of Wasp CLI we ship commands which can affect the host OS.
To run these commands in a safe manner, I've decided to create ContainerTest concept which executes commands in isolated containers.
These are: install (actually outside of CLI), uninstall, completions and telemetry.

What I want to avoid is having to build wasp-cli binary inside of the container because that takes long.
For that reason these tests are currently skipped on the macOS, because it's binary can't be run inside of the container.

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Add a regression test if needed

If you did a bug fix, make sure you satisfy the following:

  1. I added a regression test that reproduces the bug and verifies the fix.

If you're unable to add a regression test, please explain why.
This likely indicates that our current testing setup needs improvement.

Test Coverage

Please ensure your changes are adequately tested:

  1. My changes are covered by tests (unit, integration, or e2e tests as appropriate).

If you're unable to add tests or if coverage is partial, please explain why below:

Update example apps if needed

If you did code changes and added a new feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp and its e2e tests as needed and manually checked it works correctly.

If you did code changes and updated an existing feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp and its e2e tests as needed and manually checked it works correctly.

Update starter apps if needed

If you did code changes and updated an existing feature, make sure you satisfy the following:

  1. I updated starter skeleton as needed and manually checked it works correctly.
  2. I updated basic starter as needed and manually checked it works correctly.
  3. I updated todo-ts starter as needed and manually checked it works correctly.
  4. I updated embeddings starter as needed and manually checked it works correctly.
  5. I updated saas starter as needed and manually checked it works correctly.

Update e2e tests if needed

If you did code changes and changed Wasp's code generation logic, make sure you satisfy the following:

  1. [] I updated e2e tests as needed and manually checked they are correct.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2025

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7910b6
Status: ✅  Deploy successful!
Preview URL: https://5c0e5b8d.wasp-docs-on-main.pages.dev
Branch Preview URL: https://franjo-container-tests.wasp-docs-on-main.pages.dev

View logs

# Conflicts:
#	waspc/e2e-tests/SnapshotTest/snapshots/kitchen-sink-golden/wasp-app/.wasp/out/server/.npmrc
#	waspc/e2e-tests/SnapshotTest/snapshots/kitchen-sink-golden/wasp-app/.wasp/out/web-app/.npmrc
#	waspc/e2e-tests/SnapshotTest/snapshots/wasp-compile-golden/wasp-app/.wasp/out/server/.npmrc
#	waspc/e2e-tests/SnapshotTest/snapshots/wasp-compile-golden/wasp-app/.wasp/out/web-app/.npmrc
#	waspc/e2e-tests/SnapshotTest/snapshots/wasp-migrate-golden/wasp-app/.wasp/out/server/.npmrc
#	waspc/e2e-tests/SnapshotTest/snapshots/wasp-migrate-golden/wasp-app/.wasp/out/web-app/.npmrc
@FranjoMindek FranjoMindek deleted the franjo/container-tests branch October 29, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants