db session context manager

[DrPyser]

• controller: fix db connection leak
• alembic: fix downgrade
• database.helpers: db_session utility context manager
• controller: use db_session

[wazo-community-zuul]

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/cf014f4eeb95419eafab02244fe5a31d

✔️ tox-linters SUCCESS in 5m 41s
✔️ wazo-tox-py39 SUCCESS in 6m 24s
✔️ debian-packaging-bullseye SUCCESS in 3m 48s
❌ auth-tox-integration FAILURE in 9m 43s

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wazo-community-zuul]

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/8d9031fff46743b889d293899669d85d

✔️ tox-linters SUCCESS in 5m 49s
✔️ wazo-tox-py39 SUCCESS in 6m 30s
✔️ debian-packaging-bullseye SUCCESS in 3m 46s
❌ auth-tox-integration FAILURE in 9m 36s

[DrPyser]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Reviewer Guide 🔍

(Review updated until commit 10d7eba)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Transaction Scope Using db_session() wraps reads in a transaction; confirm that downstream services called after the context do not require the session/objects as they will be detached once the session closes. with db_session(): top_tenant_uuid = self.dao.tenant.find_top_tenant() visible_tenants = self.dao.tenant.list_visible_tenants(top_tenant_uuid) tenant_uuids = [tenant.uuid for tenant in visible_tenants] self._default_policy_service.update_policies(top_tenant_uuid) self._all_users_service.update_policies(tenant_uuids) self._default_group_service.update_groups(tenant_uuids) Session Cleanup db_session() uses session.close() instead of scoped_session.remove(); verify this plays well with thread-local scoped sessions to avoid leaking connections in multi-threaded contexts. @contextmanager def db_session(): session: BaseSession = get_db_session() try: with session.begin(): yield session except Exception: session.rollback() raise finally: session.close() Query Results Lifetime Ensure 'tenants' and 'users' collections are fully materialized (e.g., not lazy-loaded attributes) before the session closes to prevent DetachedInstanceError when accessed later. with db_session(): # fetch tenants tenants = self.dao.tenant.get_missing_auth_methods( available_methods=available_authentication_methods ) # fetch users users = self.dao.user.get_missing_auth_methods( available_methods=available_authentication_methods ) tenants_authentication_methods = { tenant['default_authentication_method'] for tenant in tenants }

[QodoAI-Agent]

Persistent review updated to latest commit 10d7eba

[wazo-community-zuul]

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/55dfc675a4ce43e79b210b021243469a

✔️ tox-linters SUCCESS in 7m 29s
✔️ wazo-tox-py39 SUCCESS in 6m 31s
✔️ debian-packaging-bullseye SUCCESS in 4m 05s
❌ auth-tox-integration FAILURE in 9m 50s

[fblackburn1]

Out of Curiosity, did it cause you any issue?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wazo-community-zuul]

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/a84f49af77204842b4cb8b0117bae2bd

✔️ tox-linters SUCCESS in 6m 57s
✔️ wazo-tox-py39 SUCCESS in 7m 40s
✔️ debian-packaging-bullseye SUCCESS in 3m 44s
❌ auth-tox-integration FAILURE in 9m 13s

[DrPyser]

Out of Curiosity, did it cause you any issue?

Yep, the integration tests are failing. Will have to investigate