fix: attempt to rework release please process

.github/release-please-config.json

@@ -0,0 +1,46 @@
+{
+  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
+  "packages": {
+    "weave-gitops": {
+      "release-type": "go",
+      "changelog-path": "CHANGELOG.md",
+      "version-file": "go.mod",
+      "extra-files": [
+        "package.json",
+        "charts/gitops-server/Chart.yaml",
+        "charts/gitops-server/values.yaml"
+      ],
+      "bump-minor-pre-major": true,
+      "include-v-in-tag": true,
+      "extra-changelog-sections": [
+        {
+          "type": "feat",
+          "section": "## 🚀 Enhancements"
+        },
+        {
+          "type": "fix",
+          "section": "## 🐛 Bug Fixes"
+        },
+        {
+          "type": "docs",
+          "section": "## 📖 Documentation"
+        },
+        {
+          "type": "refactor",
+          "section": "## 🔧 Refactoring"
+        },
+        {
+          "type": "test",
+          "section": "## 🧪 Testing"
+        },
+        {
+          "type": "chore",
+          "section": "## 🛠️ Maintenance",
+          "hidden": true
+        }
+      ],
+      "pr-header": "chore",
+      "package-name": "weave-gitops"
+    }
+  }
+}

.github/workflows/pr.yaml

@@ -1,3 +1,5 @@
+name: PR CI
+
 on:
   push:
     branches:
@@ -12,12 +14,12 @@ concurrency:
   cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 
 permissions:
-  contents: read # for actions/checkout to fetch code
+  contents: read
 
-name: PR CI Workflow
 jobs:
-  ci-js:
-    name: CI Test JS
+  # Test JavaScript/UI
+  test-js:
+    name: Test JavaScript
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -27,20 +29,18 @@ jobs:
           node-version-file: package.json
           cache: yarn
       - run: make node_modules
-      - name: Check that package.json & package-lock.json were updated in commit
-        run: |
-          echo "Using node.js "$(node --version)
-          echo "Using Yarn "$(yarn --version)
-          git diff --no-ext-diff --exit-code
+      - name: Verify package files
+        run: git diff --no-ext-diff --exit-code
       - run: make ui-audit
       - run: make ui
       - run: make ui-lint
       - run: make ui-prettify-check
       - run: make ui-test
       - run: make ui-lib
 
-  ci-go:
-    name: CI Test Go
+  # Test Go code
+  test-go:
+    name: Test Go
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -52,8 +52,9 @@ jobs:
         uses: fluxcd/flux2/action@4a15fa6a023259353ef750acf1c98fe88407d4d0 # v2.7.2
       - run: make unit-tests
 
-  ci-static:
-    name: CI Check Static Checks
+  # Static analysis and code quality
+  lint:
+    name: Lint and format check
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -64,118 +65,32 @@ jobs:
       - run: make check-format
       - run: make lint
       - run: go mod tidy
-      - name: Check that go mod tidy has been run
+      - name: Verify go mod tidy
         run: git diff --no-ext-diff --exit-code
       - run: make proto
-      - name: Check that make proto has been run
+      - name: Verify proto generation
         run: git diff --no-ext-diff --exit-code
       - run: make fakes
-      - name: Check that make fakes has been run
+      - name: Verify fakes generation
         run: git diff --no-ext-diff --exit-code
 
-  build-push-image:
-    name: CI Build Image
+  # Build Docker images (but don't push on PRs)
+  build-images:
+    name: Build Docker Images
     uses: ./.github/workflows/build-push-image.yaml
     with:
       file: ${{ matrix.docker-image }}.dockerfile
       image: ghcr.io/${{ github.repository }}/${{ matrix.docker-image }}
-      push: ${{ github.event_name != 'pull_request' && github.repository == 'weaveworks/weave-gitops' }}
+      push: ${{ github.event_name != 'pull_request' }}
       tags: |
         type=ref,event=branch
         type=ref,event=pr
     permissions:
-      contents: read # for actions/checkout to fetch code
-      id-token: write # for Cosign to be able to sign images with GHA token
-      packages: write # for docker/build-push-action to push images
+      contents: read
+      id-token: write
+      packages: write
     strategy:
       matrix:
         docker-image:
           - gitops
-          - gitops-server
-
-  ci-upload-binary:
-    name: Upload Binary - Disabled
-    runs-on: ${{ matrix.os }}
-    needs: [ci-go, ci-static, ci-js]
-    strategy:
-      matrix:
-        os: [ubuntu-latest, macOS-latest]
-    if: ${{ github.event_name != 'pull_request' && github.repository == 'weaveworks/weave-gitops' }}
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - name: Setup Go
-        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - name: Clean
-        run: make clean
-      - id: gitsha
-        run: |
-          gitsha=$(git rev-parse --short ${{ github.sha }})
-          echo "sha=$gitsha" >> $GITHUB_OUTPUT
-      - name: build
-        run: |
-          make gitops
-      - name: Upload binary
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
-        with:
-          name: gitops-${{ matrix.os }}-${{ steps.gitsha.outputs.sha }}
-          path: bin/gitops
-          overwrite: true
-
-  ci-publish-js-lib:
-    name: Publish js library
-    runs-on: ubuntu-latest
-    if: "${{ github.repository_owner == 'weaveworks' && github.ref_name == 'main'}}"
-    needs: [ci-js]
-    permissions:
-      packages: write
-    outputs:
-      js-version: ${{ steps.package-version.outputs.js-version }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-        with:
-          # avoid the merge commit that on.pull_request creates
-          # fallback to github.sha if not present (e.g. on.push(main))
-          # https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit
-          # We want the correct sha so we can tag the npm package correctly
-          ref: ${{ github.event.pull_request.head.sha || github.sha }}
-          fetch-depth: 0
-      - name: Setup Node.js
-        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
-        with:
-          node-version-file: package.json
-          registry-url: "https://npm.pkg.github.com"
-          scope: "@weaveworks"
-      - run: yarn
-      - run: make ui-lib
-      - name: Update package version
-        id: package-version
-        run: |
-          GITOPS_VERSION=$(git describe)
-          echo "js-version=$GITOPS_VERSION" >> $GITHUB_OUTPUT
-          jq '.version = "'$GITOPS_VERSION'" | .name = "@weaveworks/weave-gitops-main"' < dist/package.json > dist/package-new.json
-          mv dist/package-new.json dist/package.json
-          cp .npmrc dist
-      - run: cd dist && npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-  #  release step updates 'release' status check for non releases branches. See ../../doc/incidents/issues-3907 for full context.
-  release:
-    if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.head.ref, 'releases/') && !github.event.pull_request.head.repo.fork }}
-    runs-on: ubuntu-latest
-    steps:
-      - name: Release
-        run: |
-          curl --fail --request POST \
-            --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.pull_request.head.sha }} \
-            --header 'authorization: Bearer ${{ secrets.WEAVE_GITOPS_BOT_ACCESS_TOKEN }}' \
-            --header 'content-type: application/json' \
-            --data '{
-                "state":"success",
-                "description":"release not required",
-                "context":"release"
-              }'
+          - gitops-server