-
Notifications
You must be signed in to change notification settings - Fork 771
fix(visualizer): improve dark mode styling for ShinyText component #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace solid purple text color with vibrant gradient (#a78bfa → #c084fc → #e879f9) in dark mode - Add subtle purple shine effect (15% opacity) instead of harsh white shine - Maintain animated gradient and shine animations in dark mode - Add dark mode styling for PlaygroundResult component (loading text and pre blocks) - Improve type safety in replay-scripts.ts with null checks and type normalization
❌ Deploy Preview for midscene failed. Why did it fail? →
|
Additional FixAdded a second commit to fix a bug in Issue: The function was incorrectly prioritizing Fix: Corrected the resolution order to:
Test: All Puppeteer unit tests now pass (12/12), including the previously failing |
Update: aiActionContext Priority ChangedI've updated the New Priority Order (Highest to Lowest)
Changes Made
RationaleThis design allows agent-level preferences to override target-level context, providing more flexibility for runtime configuration while maintaining backward compatibility with the deprecated |
081816a to
fc69ac9
Compare
Correction: aiActionContext PriorityI've corrected the priority order. Correct Priority Order (Highest to Lowest)
Changes Made
RationaleThis design:
|
Change the resolution priority to prefer agent-level preference over target-level context: Priority order (highest to lowest): 1. preference.aiActContext (recommended) 2. preference.aiActionContext (deprecated) 3. target.aiActionContext (target-level fallback) Updated: - Function comment to reflect correct priority order - Test cases to validate new priority behavior - Added comprehensive test coverage (5 test cases) This allows agent-level preferences to override target-level context, providing more flexibility in runtime configuration while maintaining backward compatibility with the deprecated aiActionContext property.
fc69ac9 to
7b6570c
Compare
Summary
This PR improves the dark mode visual experience for the ShinyText component and related UI elements in the visualizer package.
Changes
ShinyText Component (Dark Mode)
#c5b8ff) with a vibrant animated gradient:#a78bfa→#c084fc→#e879f9→#c084fcrgba(197, 184, 255, 0.15)(15% opacity)PlaygroundResult Component (Dark Mode)
Type Safety Improvements
replay-scripts.tsExecutionDumphandlingVisual Comparison
Before: Solid purple text (
#c5b8ff) with white shine (40% opacity) - visually jarring in dark modeAfter: Vibrant purple-pink gradient with matching purple shine (15% opacity) - harmonious and elegant
Test Plan
npm run lint- passed with auto-fixesRelated
Addresses user feedback about harsh white shine effect in dark mode while maintaining the dynamic visual appeal of the component.