Http2WebTestRequestHandler shouldn't subclass http.server.BaseHTTPRequestHandler #55699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uestHandler H1 and H2 are sufficiently different protocols that it doesn't really make any sense for this to be a subclass, and we don't actually use anything from the superclass, which shows how needless this is. Additionally, move methods from BaseWebTestRequestHandler to Http1WebTestRequestHandler where they're only used by that subclass.
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
jonathan-j-lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H1 and H2 are sufficiently different protocols that it doesn't really
make any sense for this to be a subclass, and we don't actually use
anything from the superclass, which shows how needless this is.
Additionally, move methods from BaseWebTestRequestHandler to
Http1WebTestRequestHandler where they're only used by that subclass.