fix: handle correctly semicolon on the end of the fmtp line#23
Merged
k-wasniowski merged 2 commits intomainfrom Mar 20, 2025
Merged
fix: handle correctly semicolon on the end of the fmtp line#23k-wasniowski merged 2 commits intomainfrom
k-wasniowski merged 2 commits intomainfrom
Conversation
k-wasniowski
requested review from
SomeBody16,
antsukanova,
bbaldino,
brycetham,
edvujic and
szotrabh
Collaborator
|
Just to add a bit of research that we did: Based on some links (here and here) and the spec which defines the grammar as: it appears that trailing semicolons should not technically be considered valid, but they do happen so it seems reasonable to not choke on them. |
bbaldino
reviewed
Mar 19, 2025
bbaldino
approved these changes
Mar 19, 2025
Collaborator
bbaldino
left a comment
bbaldino
left a comment
There was a problem hiding this comment.
code looks good...just tweak that comment a bit if you can
brycetham
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.