Add stub ExternalTexture and support for them in BindGroups #570
+240
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
force-pushed
the
external_texture
branch
from
3dd4fbf to
bbac315
Compare
Collaborator
kainino0x
reviewed
Nov 22, 2025
| doc: | | ||
| TODO | ||
| - name: external_texture_binding_layout | ||
| doc: Chained in @ref WGPUBindGroupLayoutEntry to specify that the corresponding entries in an @ref WGPUBindGroup will contain an @ref WGPUExternalTexture. |
Collaborator
There was a problem hiding this comment.
note, just the existence of this extension in the chain has an effect - it has no fields. Which means for example if it got flattened into the parent struct (in a v2 api) it would have to be special cased. Generally I've tried to avoid this in the past, but I can't remember offhand for sure if this would be the first one or not.
Collaborator
Author
There was a problem hiding this comment.
Yeah if we flatten it in the future, I'd expect it to become a boolean. It's a bit of a special case but seems fine. Or we can add a boolean that defaults to false and update Dawn to have that boolean as well. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL! It doesn't add creation of the external texture as that's still super implementation specific, but this will unblock folks that want to use ExternalTexture in WASM (they can import a C object from a precreated JS GPUExternalTexture).
The webgpu.h diff is slightly messy because the new chained struct force a small reordering. The additions themselves should be pretty trivial and they add a chained struct for the equivalent Rust enum option in wgpu.
I chose
ExternalTextureBindingLayoutto match theBuffer/Sampler/...BindingLayoutconvention that's already used forBindGroupLayoutEntrymembers.ExternalTextureBindingEntryis just following that. But I'm not to attached to the exact names.