Move "clean up API method tracker" to the right place #12022
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step in "commit an intercepted navigate event" that should be done when the event is *not* intercepted. This fixes a bug introduced by whatwg#11952, where accidentally removing an "Otherwise" results in calling "clean up" also for same-document navigations, and a subsequent refactor in whatwg#11987 that makes this more nonsensical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step in "commit an intercepted navigate event" that should be done when the event is not intercepted.
This fixes a bug introduced by #11952, where accidentally removing an "Otherwise" results in calling "clean up" also for same-document navigations, and a subsequent refactor in #11987 that makes this harder to trace.
cc @jnjaeschke @farre @zcorpan
/nav-history-apis.html ( diff )