Skip to content

Avoid unresolved promises in Navigation API traversal #12031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zcorpan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid unresolved promises in Navigation API traversal #12031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99859,13 +99859,20 @@ interface <dfn interface>NavigationHistoryEntry</dfn> : <span>EventTarget</span>

<li>
<p>If <var>targetSHE</var> is <var>navigable</var>'s <span
data-x="nav-active-history-entry">active session history entry</span>, then abort these
steps.</p>
data-x="nav-active-history-entry">active session history entry</span>, then:</p>

<ol>
<li><p><span>Queue a global task</span> on the <span>navigation and traversal task
source</span> given <var>navigation</var>'s <span>relevant global object</span> to
<span>reject the finished promise</span> for <var>apiMethodTracker</var> with an
<span>"<code>InvalidStateError</code>"</span> <code>DOMException</code>.</p></li>

<li><p>Abort these steps.</p></li>
</ol>

<p class="note">This can occur if a previously <span
data-x="tn-append-session-history-traversal-steps">queued</span> traversal already took us to
this <span>session history entry</span>. In that case the previous traversal will have dealt
with <var>apiMethodTracker</var> already.</p>
this <span>session history entry</span>.</p>
</li>

<li><p>Let <var>result</var> be the result of <span data-x="apply the traverse history
Expand Down