Handle promise when generating source maps#102
Open
dbisso wants to merge 4 commits intowiledal:masterfrom
Open
Handle promise when generating source maps#102dbisso wants to merge 4 commits intowiledal:masterfrom
dbisso wants to merge 4 commits intowiledal:masterfrom
Conversation
SourceMapGenerator returns a Promise which we need to wait for before getting each mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Later versions of source-map return a promise from the
SourceMapConsumerconstructor so we need to wait for it to be resolved before iterating the through the mappings.