support for prepend and append#31
Open
minimit wants to merge 3 commits intowiledal:masterfrom
minimit:master
Open
support for prepend and append#31minimit wants to merge 3 commits intowiledal:masterfrom minimit:master
minimit wants to merge 3 commits intowiledal:masterfrom
minimit:master
Conversation
// @codekit-prepend path/to/file.js // @codekit-append path/to/file.js
Author
|
I don't know how to run the tests. Will look into it if it's needed. |
|
This is brilliant. Can we get this committed? This is exactly what I need. |
Collaborator
|
All that this pull request needs now is some tests created around the use cases for this feature. I will circle back to this item after we get through the more critical PRs and resolve the conflicts if I need to. |
This was referenced Apr 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with
As I explained it's the syntax this 'precompiler' sofwares use. #30
The lines added are very simple, I just:
expand()with the new argumentregexprependString()andappendString()I cached the results, that I add tonewTextduring buffer.Also I added optional
[]on multiple files for this syntax