Add aliases option to allow named paths#90
Open
henrahmagix wants to merge 5 commits intowiledal:masterfrom
Open
Add aliases option to allow named paths#90henrahmagix wants to merge 5 commits intowiledal:masterfrom
henrahmagix wants to merge 5 commits intowiledal:masterfrom
Conversation
Also mark aliases as such in the error.
Otherwise it installs debug@4 which uses ES6 features unsupported in node v0.10
Saves on File IO time spent searching for globs that are aliases.
Collaborator
|
This is super useful, I think, and would be a great enhancement to this plugin. Let's get this in there after the dependency updates and hopefully we don't see too many collisions with other code that is also coming in. This PR will need tests written for the use cases this feature presents. If you could provide those tests in your branch, @henrahmagix, that would be super awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote this option for my uses, maybe other users would like it too? =)
It allows users with many identical require paths across their files to declare the path once and reference with a name, e.g.
//= require vendor/jquery/jquery.jsbecomes
//= require jquerywith options
I've also updated the error message to include the filepath of the include/require, and the top-level filepath at the beginning of the recursion, to aid in debugging when multiple top-level files all include/require the same file, e.g.
for a project structured like so: