Skip to content

Workaround for deprecated getScrollTop call. Fixes issue 36. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samhiatt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Workaround for deprecated getScrollTop call. Fixes issue 36. #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 69 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions src/editor/editor-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,18 @@ export class EditorManager {
var clientX = e.clientX
var clientY = e.clientY
let clientRect = lines.getBoundingClientRect()
let screenPosition = editor.element.screenPositionForPixelPosition({
top: (clientY - clientRect.top) + editor.element.getScrollTop(),
left: (clientX - clientRect.left) + editor.element.getScrollLeft()
})
let screenPosition = null
if (typeof editor.screenPositionForPixelPosition != 'undefined'){ // using new api
screenPosition = editor.screenPositionForPixelPosition({
top: (clientY - clientRect.top) + editor.element.scrollTop,
left: (clientX - clientRect.left) + editor.element.scrollLeft
})
} else { // must be using depricated api, see commit: https://github.com/atom/atom/commit/535a9da94657f92498f8bc7f3f27c07c779555d6
screenPosition = editor.element.screenPositionForPixelPosition({
top: (clientY - clientRect.top) + editor.element.getScrollTop(),
left: (clientX - clientRect.left) + editor.element.getScrollLeft()
})
}
return editor.bufferPositionForScreenPosition(screenPosition)
}

Expand Down