Skip to content

Conversation

@MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

sometimes it can happen that the work manager for notifications starts, but the app does not have internet access.

Causes (Optional)

not sure why the system is blocking internet access

Solutions

have wm wait for internet access to start running

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara
Copy link
Member Author

@claude review

@github-actions
Copy link
Contributor

🤖 Beep boop! Claude is putting on their reading glasses and diving into your code...

⏳ This comment will be updated with the review results once I'm done pondering the mysteries of your implementation.

In the meantime, feel free to grab a coffee ☕ - reviewing code is serious business!

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 7.50000% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.03%. Comparing base (cae30dc) to head (2eb9989).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...re/android/notification/WireNotificationManager.kt 9.67% 27 Missing and 1 partial ⚠️
...e/android/services/WireFirebaseMessagingService.kt 0.00% 9 Missing ⚠️

❌ Your patch check has failed because the patch coverage (7.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4391      +/-   ##
===========================================
- Coverage    47.13%   47.03%   -0.10%     
===========================================
  Files          531      531              
  Lines        17651    17686      +35     
  Branches      2988     2995       +7     
===========================================
  Hits          8319     8319              
- Misses        8444     8478      +34     
- Partials       888      889       +1     
Files with missing lines Coverage Δ
...e/android/services/WireFirebaseMessagingService.kt 0.00% <0.00%> (ø)
...re/android/notification/WireNotificationManager.kt 71.02% <9.67%> (-9.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae30dc...2eb9989. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants