-
Notifications
You must be signed in to change notification settings - Fork 43
refactor: replace amplituda with avs built-in solution v2 [WPB-19814] [WPB-16588] #4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mplituda-with-avs-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
…mplituda-with-avs-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/sendmessage/SendMessageViewModel.kt # app/src/test/kotlin/com/wire/android/ui/home/conversations/sendmessage/SendMessageViewModelTest.kt
…mplituda-with-avs-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/sendmessage/SendMessageViewModel.kt # kalium
…mplituda-with-avs-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/RegularMessageItem.kt # kalium
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
…mplituda-with-avs-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/MessageModule.kt # kalium
yamilmedina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nitpick, can be ignored :D
...n/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt
Outdated
Show resolved
Hide resolved
…mplituda-with-avs-v2 # Conflicts: # kalium
…mplituda-with-avs-v2
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
AudioNormalizedLoudnessBuilderalong with use case to update “normalized_loudness” after building itAudioMessageSliderto become adaptive/responsive and use sampling function to get proper number of elements on wave form to fit the available widthAudioMessageSliderTrack, moved totrackcomposable lambda ofSliderand changed the way progress is colored, from selecting subsequent elements to using blend mode on whole wave mask - less recompositions and it fixes situations where whole element was already painted before the slider thumb covered itDependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Send or receive any audio message or asset message with audio file.
Attachments (Optional)
amplituda_before.mp4
amplituda_after.mp4
record_and_send_before.mp4
record_and_send_after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.