Feat(json_rpc): implement new method searchDataRequests #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HashMap will not be persisted to storage. Nodes must explicitly opt-in.
Tommytrg
reviewed
Sep 15, 2025
| let reverse = msg.reverse.unwrap_or_default(); | ||
| let mut since_epoch: i64 = msg.since.unwrap_or_default(); | ||
| if since_epoch < 0 { | ||
| since_epoch = i64::from(self.current_epoch.unwrap()).saturating_add(since_epoch); |
Member
There was a problem hiding this comment.
Suggested change
| since_epoch = i64::from(self.current_epoch.unwrap()).saturating_add(since_epoch); | |
| if let Some(current) = self.current_epoch { | |
| since_epoch = i64::from(current).saturating_add(since_epoch); | |
| } |
Comment on lines
+1550
to
+1556
| .filter_map(|tuple| { | ||
| if tuple.0 >= since_epoch { | ||
| Some(*tuple) | ||
| } else { | ||
| None | ||
| } | ||
| }) |
Member
There was a problem hiding this comment.
We may use filter instead of map_filter
Suggested change
| .filter_map(|tuple| { | |
| if tuple.0 >= since_epoch { | |
| Some(*tuple) | |
| } else { | |
| None | |
| } | |
| }) | |
| .filter(|(epoch, _)| *epoch >= since_epoch) |
Contributor
Author
There was a problem hiding this comment.
changing to filter makes later collect to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.