fix(ci): update Rust toolchain to 1.89.0 for edition 2024 compatibility #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(ci): update Rust toolchain to 1.89.0 for edition 2024 compatibility (#2) This PR updates the Rust toolchain to version 1.89.0 in the CI workflow to support `edition = "2024"` in `Cargo.toml` and resolve compatibility issues with newer Rust features and lints, including `mismatched_lifetime_syntaxes`. It also ensures `rustfmt` and `clippy` are available for `just fmt` and `just clippy` steps. ### Changes - Added `dtolnay/rust-toolchain@stable` with `toolchain: 1.89.0` and `components: rustfmt,clippy` in `.github/workflows/pull_request.yml`. ### Related Issues - Fixes failing CI in PRs due to `edition = "2024"` incompatibility with older Rust versions.
Author
|
Check job in my repo fork success. |
fix(ci): replace docker-compose with docker compose plugin and remove redundant setup This PR replaces the deprecated Python-based `docker-compose` (v1) with the modern `docker compose` (v2, Go-based plugin) in the `Justfile` for the `e2e-stable` and `e2e-debug` recipes. It also removes the redundant `docker/setup-compose-action` from `midnight.yml`, as `docker compose` is already available in the CI environment. These changes ensure compatibility with newer Docker CLI versions, fixing failing end-to-end tests. ### Changes - Updated `Justfile` to use `docker compose` instead of `docker-compose` in `e2e-stable` and `e2e-debug` recipes. - Removed `docker/setup-compose-action` from `.github/workflows/midnight.yml`. ### Related Issues - Fixes failing E2E tests in CI due to deprecated `docker-compose` usage and redundant setup action.
Author
|
This PR must be merged before #2659 to ensure CI stability (resolves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ci): update Rust toolchain to 1.89.0 for edition 2024 compatibility (#2660)
This PR updates the Rust toolchain to version 1.89.0 in the CI workflow to support
edition = "2024"inCargo.tomland resolve compatibility issues with newer Rustfeatures and lints, including
mismatched_lifetime_syntaxes. It also ensuresrustfmtandclippyare available forjust fmtandjust clippysteps.Changes
dtolnay/rust-toolchain@stablewithtoolchain: 1.89.0andcomponents: rustfmt,clippyin.github/workflows/pull_request.yml.Related Issues
edition = "2024"incompatibility with older Rustversions.