Fix bug when autoFocus is set to true, and value is empty
#338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial value typed into the hour input is cleared as soon as you finish typing and move to the minutes input. Will now use `autoFocus` when setting initial value for `isOpen`, if `isOpenProps` is undefined. Explanation of the bug: The TimePicker input is focused as expected, but the `isOpen` property is not set to `true`. This causes the `isOpen` property to be set to `true` as soon as you land on the second input (minutes), which again leads to the hours being cleared.
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
0444e97 to
9ce4800
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
2e092e9 to
b0c79fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when
autoFocusis set totrue, andvalueis empty, the initial value typed into the hour input is cleared as soon as you finish typing and move to the minutes input. Will now useautoFocuswhen setting initial value forisOpen, ifisOpenPropsis undefined.Explanation of the bug: The TimePicker input is focused as expected, but the
isOpenproperty is not set totrue. This causes theisOpenproperty to be set totrueas soon as you land on the second input (minutes), which again leads to the hours being cleared.