-
Notifications
You must be signed in to change notification settings - Fork 133
Visual Studio Improvements, Introduce wolfBootTestLib #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| Common pitfalls: mismatched keystore files in different directories. | ||
|
|
||
| ## Strip wolfBoot header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below seems very hacky and very Visual Studio specific. Please move all this into an IDE/VisualStudio location and have it build from there. The below is not always true and won't always work. Please explain the problem you are trying to solve and how this related to CMake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain the problem you are trying to solve
It all started with my multiple CMake builds (Windows, Linux, VS Code, etc.); I would end up having different files in different directories vs make result. (e.g. defaults vs command-line params). I spent a considerable amount of time debugging signature failures for the same-name user settings and/or keystore files in wrong directories.
Yes, part of the problem was self-inflicted during my learning and dev process. I'm also thinking of how future users might bolt on wolfBoot to their existing project, instead of puling their project into wolfBoot: quite likely adapting their own CMake.
My objective is to prevent anyone else from encountering similar problems and instead have an easy-to-use and intuitive initial experience. See #624 and #635 on this topic.
I've been specifically working on the customer requests for (1) VS Code and (2) Windows in addition to the CMake improvements. I've been using Visual Studio myself as my primary environment for both CMake development as well as the wolfBoot C source apps.
move all this into an IDE/VisualStudio
I created the new project files in tools/keytools as they are already in the wolfBoot master branch. I understand the desire to keep wolfBoot source clean and separate from specific IDE files.
I recently had a conversation with @danielinux - We agreed that I would also try to move the VS Code from the root to instead the IDE directory as well. It really works best in the root, but I am hopeful I will be able to persuade the workspace the related files it into a subdirectory (wolfBoot.code-workspace, .vscode/launch.json, etc).
I've since updated my dev VS projects in tools/keytools as well as the test-visual-studio.yml workflow. (See sample); If you'd prefer, I can move them all into this PR, all in the IDE/VisualStudio directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain the problem you are trying to solve
I nearly forgot the original source of my signature debug deep dive: See #614 and #613
- @douzzer indicated it seemed suspicious and worthy of investigation.
- @danielinux mentioned today that not every option combo is currently supported.
Adds Visual Studio equivalent of
test-lib, updates essential source code to address Microsoft-specific issues.Introduces new
test-visual-studio.ymlworkflow test.This is related to #614 , allowing more comprehensive testing from different environments.
Other changes coming, see my dev branch
Workflow tested in dev: https://github.com/gojimmypi/wolfBoot/actions/runs/18978948256
Zendesk
See 20775
Edit:
Sample run upstream: https://github.com/wolfSSL/wolfBoot/actions/runs/18980092821/job/54210176378?pr=623
The current build-windows now fails with this PR, as the existing solution file with the new
test-lib.exeneeds the other projects to build and run.I propose the
build-windowsbe removed in favor of thetest-visual-studio.ymlworkflow test in this PR.