Customer and WCAnalyticsCustomer: Disambiguate userID and customerID
#16056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customer and WCAnalyticsCustomer are used in the app together to facilitate order creation and customer management. customerID on Customer object was sometimes overwritten by userID from WCAnalyticsCustomer making it ambiguous which one is used at what time.
When updating Storage.Customer from WCAnalyticsCustomer map both customerID and userID so they could be both used directly and unambiguously when needed
Networking.Customer is used for both WCAnalyticsCustomer and Customer use cases. Since WCAnalyticsCustomer contains both userID and customerID, we need Customer to contain both so data wouldn't be lost in the conversion
Customer filter in orders doesn't work for non-registered users (that don't have userID set)
1 task
Generated by 🚫 Danger |
|
|
|
Version |
|
Version |
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More information in this PR: #16055
WCAnalyticsCustomerandCustomerare tightly coupled in the app. We mostly seeStorage.Customercreated fromWCAnalyticsCustomerafter fetching data fromwc-analytics/customerand then additionally fetching data from/customers/{userID}if additional data could be loaded from the registered user.WCAnalyticsCustomercontains bothcustomerID(unique ID for customer that has made an order), anduserID(unique ID for a registered user on the WP site).However
Storage.Customeronly containscustomerIDwhich sometimes is set to WCAnalyticsCustomer.userID value which makes codebase around customers hard to grasp.I tried to disambiguate and explicitly use
userIDorcustomerIDwhen needed:userIDtoCustomerentity with new model and migration testsuserIDandcustomerIDSteps to reproduce
TBD: I still need extensive testing
Testing information
Screenshots
RELEASE-NOTES.txtif necessary.