Skip to content

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Oct 16, 2025

Description

Progress view remains visible on the navigation bar (toolbar) due to iOS 26 using a different toolbar item style.

Hide it after loading.

Steps to reproduce

Prerequisite: remove UIDesignRequiresCompatibility from Info.plist to enable iOS26

  1. Menu
  2. Payments
  3. Confirm progress view appears in the toolbar and disappears after loading

Testing information

Tested on iPad 18.5 simulator and iPad 26 device

Screenshots

Before

image >

After

ScreenRecording_10-16-2025.17-02-08_1.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 23.5 milestone Oct 16, 2025
@staskus staskus requested a review from iamgabrielma October 16, 2025 14:07
@staskus staskus added Bug iOS 26 Specific to iOS 26 labels Oct 16, 2025
@staskus
Copy link
Contributor Author

staskus commented Oct 16, 2025

@iamgabrielma not important to get into 23.5

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16251-24dd379
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit24dd379
Installation URL5a5la5i9scvc8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma modified the milestones: 23.5, 23.6 Oct 17, 2025
@iamgabrielma iamgabrielma self-assigned this Oct 20, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

PD: We do not need to use ActivityIndicator here, right? I haven't tested in different iOS or devices but I see this was a wrapper meant for handling <iOS13 cases, but we could use just ProgressView at this point. Happy to open a task in linear to get rid of all its instances as backlog.

@staskus
Copy link
Contributor Author

staskus commented Oct 20, 2025

but we could use just ProgressView at this point. Happy to open a task in linear to get rid of all its instances as backlog.

@iamgabrielma, excellent observation, we definitely should!

Happy to open a task in linear to get rid of all its instances as backlog.

Sounds good!

@staskus staskus merged commit a5f48e9 into trunk Oct 20, 2025
21 of 25 checks passed
@staskus staskus deleted the woomob-1352-ios-26-menu-payments-fix-empty-navigation-bar-item branch October 20, 2025 06:34
@iamgabrielma
Copy link
Contributor

Logged as WOOMOB-1539 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug iOS 26 Specific to iOS 26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants