-
Notifications
You must be signed in to change notification settings - Fork 120
Auto authenticate users in web views #16318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as described. Pre-approving. Left 1 comment.
Also noticed 1 second delay between displaying store name upon app launch.
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2025-11-06.at.19.55.29.mov
| <CommandLineArgument | ||
| argument = "-simulate-stripe-card-reader" | ||
| isEnabled = "NO"> | ||
| isEnabled = "YES"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I accidentally committed that after testing. Reverted in 58a0ac8.
|
Thanks for the review Rafael.
I hope this is still better than the longer delay earlier? I'll enable auto-merge for now, but please let me know if something else can be done here. |

Closes WOOMOB-1432
Description
This PR updates the behavior of web views on the app to auto-authenticate users whenever possible. Changes include:
shouldAuthenticateAdminPageto check for SSO module rather than for WPCom sites. This follows the changes made in Improve authentication logic for authenticated web view #15164.AuthenticatableWebViewthat checks for admin URL and authenticates user automatically if the above conditions are met.Test Steps
Before testing each case, it's best to delete the app to avoid existing cookies causing false positive test results. For each test, use a site that supports Jetpack SSO (either atomic site, or self-hosted site with Jetpack SSO enabled from the settings), or log in to a self-hosted store with site credentials.
TC1:
shouldAuthenticateAdminPageSimulator.Screen.Recording.-.iPhone.17.-.2025-11-06.at.16.01.04.mov
TC2: Site with HTTP scheme
Repeat the steps in TC1.
TC3: custom field URLs
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-06.at.16.02.02.mov
TC4: IPP plugin setup
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-06.at.16.06.00.mov
TC5: adding tax rates
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-06.at.16.08.18.mov
TC6: store name on app start up.
RELEASE-NOTES.txtif necessary.