fix(schema): accept positive integers and false as valid default_limit #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #602
Small Issue though:
Setting
default_limit: falserequires an explicit limit to be passed via the%Flop{}struct, otherwise queries just break onfirst/limit/page_sizecan't be blank.The current behaviour of
-1though defaults to returning all results, just like usingRepo.all, which is our current usecase.So my proposal would be to update the typing to
{:or, [:pos_integer, {:in, [false, -1]}]}and updating the docs to refelct that.Thoughts? @woylie