Skip to content

Conversation

@pizzamx
Copy link

@pizzamx pizzamx commented Jul 1, 2025

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

pizzamx added 5 commits July 1, 2025 21:05
git-subtree-dir: script.subtitles.zimukux
git-subtree-split: 29b8395d04245359575db70f42cadab6ba7ec6b7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted? the GPL-2.0-or-later should included I think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, removed the LICENSE by mistake.

@basrieter basrieter added the Don't Merge Do not merge this PR label Jul 5, 2025
@basrieter basrieter removed the Don't Merge Do not merge this PR label Jul 6, 2025
Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (Team Kodi) had a discussion regarding the OCR for the Captcha. The Captcha is there for a reason: to prevent automated scraping. However, this not a (automated) scraper add-on, the OCR is done on a per-subtitle base. So wil will allow this kind of functionality in this add-on.

@basrieter basrieter merged commit 0f6b10b into xbmc:matrix Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants