dialects: (qft) initialise dialect #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
approved these changes
Mar 5, 2025
| class QFTAttr(GateAttr): | ||
| name = "qft.n" | ||
|
|
||
| num_qubits_param: ParameterDef[IntAttr] |
Collaborator
There was a problem hiding this comment.
Suggested change
| num_qubits_param: ParameterDef[IntAttr] | |
| qubits: ParameterDef[IntAttr] |
Would this be simpler?
|
|
||
| @irdl_attr_definition | ||
| class QFTAttr(GateAttr): | ||
| name = "qft.n" |
Collaborator
There was a problem hiding this comment.
The alternative to this would be to have an algorithm or algo dialect and put qft inside. Do you see anything else being in this dialect?
|
|
||
| "test.op"() {gate = #qft.n<5>} : () -> () | ||
|
|
||
| // CHECK: "test.op"() {gate = #qft.n<5>} : () -> () |
Collaborator
There was a problem hiding this comment.
Could have a test with a use of the gate to check that number of qubits is working correctly
Collaborator
|
@kimxworrall what's the plan with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a QFT dialect with the same motivation as the QEC dialect.
Adds the QFT GateAttr which has an integer parameter - this indicates the number of qubits the gate this attr is attached to acts on.