Skip to content

Conversation

@kphowell
Copy link

I have uploaded to sets of tags that Will extracted from ODIN, as well as documentation in the README

kphowell added 4 commits June 12, 2019 09:37
Added documentation in the README for the files odin_lexicon.txt and odin_lookup.txt
@goodmami
Copy link
Member

I don't think I should be the one to approve since I don't know the context, but I have some comments:

  • Why are the files added to this repo? They do not seem to be used by the code, so I'm failing to see their relevance here. Maybe they need their own repo?
  • Assuming we want them here, it might be nice to organize them under a tagsets/ directory or something.
  • Do the tag sets fall under a different license? It sounds like they are from Will and Fei's earlier work; if they want them to be under this repo's license, we should document their approval in the README or somewhere ("permission to redistribute given by ... on ...").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants