Skip to content

Made phone number regex more flexible #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Made phone number regex more flexible #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/lib/parse-resume-from-pdf/extract-resume-from-sections/extract-profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ const hasAt = (item: TextItem) => item.text.includes("@");
// Phone
// Simple phone regex that matches (xxx)-xxx-xxxx where () and - are optional, - can also be space
export const matchPhone = (item: TextItem) =>
item.text.match(/\(?\d{3}\)?[\s-]?\d{3}[\s-]?\d{4}/);
item.text.match(
/(?:\+?\d{1,3}[-.\s]?)?(?:\(?\d{1,4}\)?[-.\s]?){1,4}\d{1,4}/
);
const hasParenthesis = (item: TextItem) => /\([0-9]+\)/.test(item.text);

// Location
Expand Down
4 changes: 4 additions & 0 deletions ...b/parse-resume-from-pdf/extract-resume-from-sections/extract-resume-from-sections.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ describe("extract-profile tests - ", () => {
expect(matchPhone(makeTextItem(" (123)456-7890 "))![0]).toBe(
"(123)456-7890"
);
expect(matchPhone(makeTextItem("+1 123-456-7890"))![0]).toBe("+1 123-456-7890");
expect(matchPhone(makeTextItem("+44 20 7946 0958"))![0]).toBe("+44 20 7946 0958");
expect(matchPhone(makeTextItem("+91-98765-43210"))![0]).toBe("+91-98765-43210");
expect(matchPhone(makeTextItem("0049 30 123456"))![0]).toBe("0049 30 123456");
});

it("Url", () => {
Expand Down