Fix crash on multiple start/stop due to FD being closed twice #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjasonlyu
force-pushed
the
fix/stop-fd-double-close
branch
from
c61a96a to
8ce1a2c
Compare
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, when calling start() and stop() multiple times in a VPN application using tun2socks, the program crashes with:
This happens because both
_defaultDevice.Close()and_defaultStack.Wait(), which are called insidestop(), attempt to close the same file descriptor. The issue was observed when using ParcelFileDescriptor from VpnService, where the FD is detached and passed to the tun2socks engine.