XCOMMONS-3470: Easier importmap declaration for webjars #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
manuelleduc
force-pushed
the
XCOMMONS-3470
branch
from
1bd2166 to
add2b86
Compare
manuelleduc
commented
Nov 10, 2025
manuelleduc
commented
Nov 10, 2025
manuelleduc
commented
Nov 10, 2025
| if (isSelf) { | ||
| continue; | ||
| } | ||
| if (dependencies.stream().noneMatch( |
Contributor
Author
There was a problem hiding this comment.
TODO: also add a check that the path is corresponding to an existing file in the jar.
manuelleduc
commented
Nov 13, 2025
...commons-core/xwiki-commons-webjars/src/main/java/org/xwiki/webjars/WebjarPathDescriptor.java
Show resolved
Hide resolved
manuelleduc
commented
Nov 13, 2025
xwiki-commons-core/xwiki-commons-webjars/src/main/java/org/xwiki/webjars/WebjarDescriptor.java
Outdated
Show resolved
Hide resolved
manuelleduc
commented
Nov 14, 2025
| { | ||
| @Inject | ||
| private MavenProject project; | ||
| protected MavenProject project; |
Contributor
Author
There was a problem hiding this comment.
Visibility change to be able to call project.getArtifacts() on JavascriptImportMapCheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
Clarifications
Screenshots & Video
N/A
Executed Tests
Expected merging strategy