(DO NOT MERGE) - To get Changelogs

[Prasad2291]

Description

Testing

Additional Notes

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @Prasad2291, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a suite of significant improvements across the application, enhancing both developer experience and user functionality. It standardizes commit practices, refines deployment strategies for core services like Vespa and Prometheus, and expands the frontend's ability to display diverse document types. The workflow builder is now more robust with dynamic agent creation and better change management, while new features for user and API key administration provide greater control and security. A core focus has also been placed on improving the accuracy and relevance of AI interactions through comprehensive timezone awareness.

Highlights

• Commitizen and Husky Integration: Introduced Husky hooks and Commitizen configuration to enforce conventional commit messages, ensuring consistent commit formatting and enabling automated release management.
• Vespa Deployment and Configuration Updates: Updated Vespa Dockerfiles and Docker Compose configurations to use specific Vespa image versions, streamlined ONNX runtime installation, and added advanced JVM arguments for better memory management and GPU resource allocation. Prometheus configurations were also updated to support dynamic port injection using envsubst.
• Enhanced Frontend Document Viewers: Added new frontend components for viewing CSV, Excel, and plain text files. The PDF viewer was refactored to use react-pdf with virtualized scrolling and improved navigation, along with a new debug modal for inspecting Vespa document data.
• Improved ChatBox Functionality: Refactored the ChatBox component to use a new SmartTooltip component, directly utilize useToast for notifications, and implement more robust model selection logic with localStorage persistence. The Enter key behavior was refined, and clipboard copy now cleans citation numbers from the response text.
• Workflow Builder Enhancements: The Workflow Builder received significant updates, including dynamic agent creation for AI agent tools, a workflow hashing mechanism to track unsaved changes, and integration of Snackbar and ConfirmationPopup for user feedback. The header component was also refactored to support saving and refreshing workflows with proper change management.
• Comprehensive User and API Key Management: New API endpoints and a dedicated frontend page were introduced for managing users, including listing logged-in and ingested users, updating user roles, and triggering manual syncs for Google Workspace and Slack. A robust API key management system was implemented, allowing users to generate, list, and revoke API keys with granular scope and agent access controls.
• Timezone Awareness in AI Interactions: Implemented timezone handling across various AI prompts and context builders, ensuring that all date and time mentions in AI responses and internal processing respect the user's local timezone.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/release.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a wide range of significant features and refactorings across the deployment, frontend, and backend. Key changes include the integration of Commitizen for standardized commits, major enhancements to deployment scripts for better configuration and robustness, and a complete overhaul of the PDF viewer on the frontend for improved performance and features. The backend sees substantial updates with new user management APIs, API key scope enforcement for security, and more sophisticated handling of data context in chat and agent interactions, including timezone awareness. While the overall changes are impressive and move the project forward, I've identified a critical issue in the workflow logic where AI agents are created on every execution, which needs to be addressed. I've also noted a few areas for improvement in code clarity and potential performance optimizations.

[gemini-code-assist]

A new AI agent is created every time this tool is executed in a workflow. This will lead to a large number of agents being created, which is inefficient and will quickly pollute the agents table. This could also incur unnecessary costs and management overhead.

Consider implementing a strategy to reuse agents. For example, you could create a single, dedicated agent for this workflow tool when the workflow template is created, and then reuse that agent's ID for all subsequent executions. Alternatively, you could search for an existing agent with a specific name or tag before creating a new one.

[gemini-code-assist]

The unique constraint for collection names has been changed from (workspaceId, name) to (ownerId, name). This is a significant semantic change. It implies that collection names must now be unique per user across the entire system, rather than unique within a workspace. This could prevent different users in the same workspace from creating collections with the same name (e.g., "My Documents"). Please confirm if this change was intentional, as it might impact user experience.

[gemini-code-assist]

The nested ternary operator here makes the logic difficult to follow. Consider refactoring this for better readability by extracting the condition into a boolean variable. This will make the component's rendering logic clearer and easier to maintain.

        const shouldRenderStyledCitation = isNumericChild && !(citation && citation.title?.endsWith(".pdf") && citation.chunkIndex !== undefined);

        return shouldRenderStyledCitation ? (
          <span
            className="inline-flex items-center justify-center min-w-[18px] h-[18px] px-[6px] py-[2px] mx-[2px] bg-gray-200 hover:bg-gray-300 dark:bg-gray-900 dark:hover:bg-gray-800 text-gray-700 dark:text-gray-300 rounded-full text-[10px] font-mono font-medium cursor-pointer transition-colors duration-150 no-underline"
            style={{ textDecoration: "none" }}
          >
            {children}
          </span>
        ) : ( children );

[gemini-code-assist]

This function recursively fetches all items within specified folders. For deeply nested or very large collections, this could lead to performance issues due to multiple database queries in a loop. Consider adding safeguards like a depth limit or fetching items in a more optimized way, perhaps with a recursive CTE if the database supports it, to prevent potential performance bottlenecks.

[gemini-code-assist]

Fetching the workflowName from the database inside a loop can be inefficient, especially if the same workflow is processed multiple times. It would be more performant to fetch the execution details, including the name, once outside the loop and pass it down or access it from a shared context.