Sprint_4 #13
Open
Sprint_4 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKitIt
reviewed
Jul 26, 2025
tests.py
Outdated
|
|
||
| # класс TestBooksCollector объединяет набор тестов, которыми мы покрываем наше приложение BooksCollector | ||
| # обязательно указывать префикс Test | ||
| name_n_genre = [["Тень за стеной", "Ужасы"], |
Collaborator
There was a problem hiding this comment.
Нужно исправить: тестовые данные хранятся в data
AlexKitIt
reviewed
Jul 26, 2025
tests.py
Outdated
Comment on lines
11
to
17
| @pytest.fixture | ||
| def collector_with_books(self): | ||
| collector = BooksCollector() | ||
| for name, genre in name_n_genre: | ||
| collector.add_new_book(name) | ||
| collector.set_book_genre(name, genre) | ||
| return collector |
Collaborator
There was a problem hiding this comment.
Нужно исправить: фикстуры живут в модуле conftest
AlexKitIt
reviewed
Jul 26, 2025
|
|
||
| # напиши свои тесты ниже | ||
| # чтобы тесты были независимыми в каждом из них создавай отдельный экземпляр класса BooksCollector() | ||
| assert set(list_favorite_books) == {first_book, second_book} |
Collaborator
There was a problem hiding this comment.
Нужно исправить: отсутствуют тесты на проверку методов get_book_genre и get_list_of_favorites_books
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Тестирование приложения BooksCollector