issue-4664: eliminate redundant buffer allocation and data copying in TReadDataActor when reading into iovecs #4790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmyagkov
added
the
filestore
antonmyagkov
changed the title
Contributor
antonmyagkov
force-pushed
the
users/myagkov/issue-4664-service-actor-zero-copy-read
branch
2 times, most recently
from
1703321 to
47a8cb7
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 47a8cb7.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 47a8cb7.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 47a8cb7.
|
antonmyagkov
changed the title
antonmyagkov
force-pushed
the
users/myagkov/issue-4664-service-actor-zero-copy-read
branch
from
47a8cb7 to
3068f8d
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3068f8d.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3068f8d.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3068f8d.
|
antonmyagkov
force-pushed
the
users/myagkov/issue-4664-service-actor-zero-copy-read
branch
2 times, most recently
from
e5be71b to
56f752e
Compare
Contributor
antonmyagkov
force-pushed
the
users/myagkov/issue-4664-service-actor-zero-copy-read
branch
from
d6c3aa9 to
1bc7e40
Compare
Contributor
antonmyagkov
force-pushed
the
users/myagkov/issue-4664-service-actor-zero-copy-read
branch
from
1bc7e40 to
20c4efd
Compare
Contributor
antonmyagkov
changed the title
antonmyagkov
commented
Dec 23, 2025
| BlockBuffer->ReserveAndResize(ReadRequest.GetLength()); | ||
| TargetBuffers = CreateRope(*BlockBuffer); | ||
| } else { | ||
| TargetBuffers = CreateRope(ReadRequest.GetIovecs()); |
Collaborator
Author
There was a problem hiding this comment.
The main change is here: buffers or iovecs are now wrapped into a rope, eliminating block buffer allocation and the following data copy from block buffer into the iovecs.
antonmyagkov
commented
Dec 23, 2025
| namespace { | ||
|
|
||
| template <bool Owner = false> | ||
| class TIovecContiguousChunk: public IContiguousChunk |
Collaborator
Author
There was a problem hiding this comment.
TIovecContiguousChunk was moved from service_actor_writedata.cpp
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #4664
Handle reading to buffer and iovecs in the same way by wrapping buffer/iovecs into the rope.