Skip to content

[Blockstore] Use templatable Volume Monitoting dashboard URL on the monitoring pages #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
debnatkh merged 13 commits into from
Dec 29, 2025
Merged

[Blockstore] Use templatable Volume Monitoting dashboard URL on the monitoring pages #4826

debnatkh merged 13 commits into from
Dec 29, 2025

Conversation

@akilvein
Copy link
Contributor

@akilvein akilvein commented Dec 11, 2025

  • Add config settings for grafana dashboards
  • GetMonitoringVolumeUrl returns link to grafana volume dashboard if grafana url is configured

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

debnatkh
debnatkh reviewed Dec 15, 2025
View reviewed changes
@debnatkh debnatkh mentioned this pull request Dec 17, 2025
Merged
debnatkh
debnatkh reviewed Dec 17, 2025
View reviewed changes
@akilvein akilvein changed the title Use grafana monitoring volume dasboard if available Evaluate Volume Monitoting dashboard URL using template from diagnostics config Dec 17, 2025
@debnatkh debnatkh added ok-to-test Label to approve test launch for external members blockstore Add this label to run only cloud/blockstore build and tests on PR labels Dec 18, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 685f1b3.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5628 5627 0 0 0 1 0

@akilvein akilvein force-pushed the users/akilvein/volume-monitoring-url branch from 685f1b3 to aa3b9bc Compare December 18, 2025 12:40
debnatkh
debnatkh reviewed Dec 18, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit aa3b9bc.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5649 5648 0 0 0 1 0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 3bc18eb.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5649 5648 0 0 0 1 0

debnatkh
debnatkh previously approved these changes Dec 19, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5650 5648 0 1 0 1 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
2 1 0 1 0 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
2 1 0 1 0 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 12daad7.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5650 5649 0 0 0 1 0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit f81fa12.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5651 5650 0 0 0 1 0

debnatkh
debnatkh previously approved these changes Dec 22, 2025
View reviewed changes
@debnatkh debnatkh changed the title Evaluate Volume Monitoting dashboard URL using template from diagnostics config [Blockstore] Use templatable Volume Monitoting dashboard URL on the monitoring pages Dec 24, 2025
agalibin
agalibin reviewed Dec 24, 2025
View reviewed changes
agalibin
agalibin reviewed Dec 24, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ef84aee.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5651 5650 0 0 0 1 0

@debnatkh debnatkh merged commit c3c3160 into ydb-platform:main Dec 29, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@debnatkh debnatkh debnatkh approved these changes

@agalibin agalibin agalibin approved these changes

Assignees

No one assigned

Labels

blockstore Add this label to run only cloud/blockstore build and tests on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akilvein @debnatkh @agalibin