DiskStateUpdate is only saved if the disk is in SupportedNotications #4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
Contributor
vladstepanyuk
previously approved these changes
Dec 18, 2025
Contributor
| TVector<TDiskStateUpdate> updates = statePtr->GetDiskStateUpdates(); | ||
| UNIT_ASSERT(dbUpdates.size() == updates.size()); | ||
| for(size_t i = 0; i < dbUpdates.size(); ++i) { | ||
| UNIT_ASSERT(google::protobuf::util::MessageDifferencer::Equals(dbUpdates[i].State, updates[i].State)); |
Contributor
vladstepanyuk
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4873
In some cases, for example, when a disk is deleted and its id is no longer present in SupportsNotifications, records of its updates appear in the database, but everything remains the same in DiskRegistryState.
To solve this problem DiskStateUpdate will be appeared in the database only if disk_id is specified in SupportsNotifications