Delete unused LongTxWrites SmallBlobs InsertTable #31683
Conversation
zverevgeny
commented
Jan 4, 2026
zverevgeny
commented
- Not for changelog (changelog entry is not required)
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull request overview
This PR removes unused database schema tables and associated code from the columnshard component, specifically deleting LongTxWrites, SmallBlobs, and InsertTable related functionality that is no longer needed.
Key Changes:
- Removed InsertTable schema version checking logic from the schema version normalizer
- Deleted the entire insert_table normalizer module (broken_dedup implementation)
- Removed schema definitions for LongTxWrites, SmallBlobs, and InsertTable tables
- Cleaned up SmallBlobs table initialization and compression configuration code
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ydb/core/tx/columnshard/normalizer/schema_version/version.cpp | Removes code that collected schema versions from the now-deleted InsertTable |
| ydb/core/tx/columnshard/normalizer/insert_table/ya.make | Deletes build configuration for the deprecated insert_table normalizer module |
| ydb/core/tx/columnshard/normalizer/insert_table/broken_dedup.h | Removes header file for insertion deduplication normalizer that's no longer needed |
| ydb/core/tx/columnshard/normalizer/insert_table/broken_dedup.cpp | Removes implementation of the unused insertion deduplication normalizer |
| ydb/core/tx/columnshard/columnshard_schema.h | Renames enum values to indicate deprecated status, removes table schema structs, and comments out helper functions for deleted tables |
| ydb/core/tx/columnshard/columnshard__init.cpp | Removes SmallBlobs table compression and compaction policy configuration that's no longer needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // static void SaveLongTxWrite(NIceDb::TNiceDb& db, const TInsertWriteId writeId, const ui32 writePartId, const NLongTxService::TLongTxId& longTxId, const std::optional<ui32> granuleShardingVersion) { | ||
| // NKikimrLongTxService::TLongTxId proto; | ||
| // longTxId.ToProto(&proto); | ||
| // TString serialized; | ||
| // Y_ABORT_UNLESS(proto.SerializeToString(&serialized)); | ||
| // db.Table<LongTxWrites>().Key((ui64)writeId).Update( | ||
| // NIceDb::TUpdate<LongTxWrites::LongTxId>(serialized), | ||
| // NIceDb::TUpdate<LongTxWrites::WritePartId>(writePartId), | ||
| // NIceDb::TUpdate<LongTxWrites::GranuleShardingVersion>(granuleShardingVersion.value_or(0)) | ||
| // ); | ||
| // } | ||
|
|
||
| // static void EraseLongTxWrite(NIceDb::TNiceDb& db, const TInsertWriteId writeId) { | ||
| // db.Table<LongTxWrites>().Key((ui64)writeId).Delete(); | ||
| // } |
There was a problem hiding this comment.
Consider removing these commented-out functions entirely instead of leaving them as comments. Since the LongTxWrites table has been removed and these functions reference a non-existent table struct, keeping them as commented code adds maintenance burden without providing value. If historical reference is needed, the code will remain available in version control history.
2 participants
