-
Notifications
You must be signed in to change notification settings - Fork 743
Test for KNN brute force vector search using followers #31709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new test VectorSearchKnnPushdownFollower to verify that KNN brute force search works correctly with follower replicas. The test validates that vector search queries can be executed on followers using StaleRO transactions and that VectorTopK pushdown happens correctly.
Key changes:
- Added a new test that verifies KNN search with followers for both StaleRO and SerializableRW transaction modes
- Refactored common verification logic into a reusable
VerifyVectorSearchResultshelper function - Made table creation more flexible by adding a
singlePartitionparameter to support follower tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3fdee55 to
790b76f
Compare
|
⚪
🟢 |
|
🟢 |
|
⚪
🟢 |
Changelog entry
It's allowed to use KNN brute force search using followers in a single partition.
Check that:
Changelog category
Description for reviewers
...