Skip to content

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Jan 8, 2026

Changelog entry

It's allowed to use KNN brute force search using followers in a single partition.
Check that:

  • read from followers
  • pushdown works

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings January 8, 2026 17:24
@azevaykin azevaykin requested a review from a team as a code owner January 8, 2026 17:24
@azevaykin azevaykin enabled auto-merge (squash) January 8, 2026 17:24
@ydbot
Copy link
Collaborator

ydbot commented Jan 8, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@azevaykin azevaykin requested a review from vitalif January 8, 2026 17:28
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

2026-01-08 17:28:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7480ed4 has started.
2026-01-08 17:29:37 UTC Artifacts will be uploaded here
2026-01-08 17:33:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

2026-01-08 17:29:08 UTC Pre-commit check linux-x86_64-release-asan for 7480ed4 has started.
2026-01-08 17:29:50 UTC Artifacts will be uploaded here
2026-01-08 17:31:59 UTC ya make is running...
2026-01-08 17:33:07 UTC Check cancelled

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new test VectorSearchKnnPushdownFollower to verify that KNN brute force search works correctly with follower replicas. The test validates that vector search queries can be executed on followers using StaleRO transactions and that VectorTopK pushdown happens correctly.

Key changes:

  • Added a new test that verifies KNN search with followers for both StaleRO and SerializableRW transaction modes
  • Refactored common verification logic into a reusable VerifyVectorSearchResults helper function
  • Made table creation more flexible by adding a singlePartition parameter to support follower tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

2026-01-08 17:33:36 UTC Pre-commit check linux-x86_64-release-asan for 940e16f has started.
2026-01-08 17:33:42 UTC Artifacts will be uploaded here
2026-01-08 17:35:05 UTC ya make is running...
🟢 2026-01-08 17:37:30 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 58 0 0 0 0

🟢 2026-01-08 17:37:38 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🟢 2026-01-08 17:48:58 UTC The validation of the Pull Request description is successful.

@azevaykin azevaykin changed the title Test for KNN brute force search using followers Test for KNN brute force vector search using followers Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

2026-01-08 18:03:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 940e16f has started.
2026-01-08 18:04:06 UTC Artifacts will be uploaded here
2026-01-08 18:15:45 UTC ya make is running...
🟢 2026-01-08 18:18:09 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 58 0 0 0 0

🟢 2026-01-08 18:18:16 UTC Build successful.

@azevaykin azevaykin disabled auto-merge January 8, 2026 18:11
@azevaykin azevaykin enabled auto-merge (squash) January 8, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants