fix: explicitly use series to derive action allowed#1218
Open
marcomariscal wants to merge 2 commits intomasterfrom
Open
fix: explicitly use series to derive action allowed#1218marcomariscal wants to merge 2 commits intomasterfrom
marcomariscal wants to merge 2 commits intomasterfrom
Conversation
✅ Deploy Preview for yield-v2-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to prevent bugs where the series is null for some reason, inaccurately preventing the action.
there's still some implicit series handling because we get
selectedSeriessome times fromuserState, which we should try to mitigate going forward. ie: if handling a vault, we should be getting the selected vault's associated series (more explicit/accurate), not just getting theselectedSeriesfrom global state.