Open
Conversation
Collaborator
|
@iamsahu this PR is in draft, if it's ready for review, please change the status. |
sgzsh269
reviewed
Aug 7, 2023
| return dataclass_to_container_params(self) | ||
|
|
||
| def fetch_tvl(protocol) -> str: | ||
| url = f"https://api.llama.fi/tvl/{protocol}" |
Collaborator
There was a problem hiding this comment.
Wondering how are users supposed to know the canonical name/protocol slug that Defillama supports, like what would be the canonical name for the Yield protocol
We may need to have a normalizer that is able to map parsed protocol name to Defillama's protocol slug
sgzsh269
reviewed
Aug 22, 2023
Collaborator
sgzsh269
left a comment
sgzsh269
left a comment
There was a problem hiding this comment.
@iamsahu quickly did another pass on this PR
- Please resolve the merge conflicts
- Did you get a chance to look my comment https://github.com/yieldprotocol/cacti-backend/pull/210/files#r1286288048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.