Open
Conversation
sgzsh269
reviewed
May 16, 2023
| # Check if status code is 400 | ||
| if response.status_code == 400: | ||
| # Write the request data to a file with the current time in the filename | ||
| filename = f"error_{time.strftime('%Y%m%d_%H%M%S')}.txt" |
Collaborator
There was a problem hiding this comment.
Since this function is called for every Web3 request that is routed/forwarded, it seems like this logic would create a new error log file for every 400 that is encountered
Ideally, you would want to setup the error log file at the start of the session and re-use that to capture all the errors in a single file, similar to how it is being done for the existing log file
https://github.com/yieldprotocol/chatweb3-backend/blob/dev/discovery/playwright_browser.py#L208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we should merge, just wanted to share this code.