Asap 202 upgrade react and testing library #4632
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AimeurAmin
force-pushed
the
ASAP-202-Upgrade-react-and-testing-library
branch
from
e0deae5 to
edcfaef
Compare
Collaborator
|
Do you think it's worth keeping it open @AimeurAmin ? |
damianmr
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASAP-202
Notion link
This PR covers upgrading react, react-dom to v18 and testing-library/react, testing-library/user-event to v14
Everything should be working on the deployement, also typechecks, lint issues are all fixed, yet not all tests are fixed yet.
to test this locally run the following command:
find . -name "node_modules" -type d -prune -exec rm -rf '{}' +yarn cache cleanyarn