Gh48 resolve breaks when not installed in opt

[vincentullmann]

draft PR while I'm waiting for user feedback

Changelog Description

Add support for a custom RESOLVE_ROOT environment variable to specify resolve install location

Additional review information

This change introduces a check for a RESOLVE_ROOT environment variable to determine Resolves installation directory. If the variable is not defined, the logic falls back to the default path: /opt/resolve.

Testing notes:

1. install resolve in a non standard location
2. define RESOLVE_ROOT to point to that location
3. launch resolve.

To be discussed:

For the current implemented I've picked the simplest approach to allow user testing.
However while revieing I started wondering whether it might be more flexible to allow users to define RESOLVE_SCRIPT_API, RESOLVE_SCRIPT_LIB, and RESOLVE_UTILITY_SCRIPTS_DIR directly instead introducing a new variable.

        if not self.launch_context.env.get("RESOLVE_SCRIPT_API"):
            # current logic 
            # ...
            #
            self.launch_context.env["RESOLVE_SCRIPT_API"] = resolve_script_api.as_posix()

        if not self.launch_context.env.get("RESOLVE_SCRIPT_LIB"):
            # current logic 
            # ...
            #
            self.launch_context.env["RESOLVE_SCRIPT_LIB"] = resolve_script_lib.as_posix()

This would provide more granular control while still preserving backward compatibility. Open to feedback on whether this direction makes more sense.

[BigRoy]

I think this would need to apply to all platforms - not just linux. Right?
Or is there a reason why this may only apply to Linux?

[vincentullmann]

Preferrably yes, we should apply the same logic for all platforms.

a complication I can see is that the folder layout doesn't share the same root folder, as it does on linux.

RESOLVE_SCRIPT_API:
    win: "{PROGRAMDATA}/Blackmagic Design/DaVinci Resolve/Support/Developer/Scripting"
    darwin: /Library/Application Support/Blackmagic Design/DaVinci Resolve/Developer/Scripting"
    linux: /opt/resolve/Developer/Scripting

RESOLVE_SCRIPT_LIB:
    win: "{PROGRAMFILES}/Blackmagic Design/DaVinci Resolve/fusionscript.dll"
    darwin: /Applications/DaVinci Resolve/DaVinci Resolve.app/Contents/Libraries/Fusion/fusionscript.so
    linux: /opt/resolve/libs/Fusion/fusionscript.so

RESOLVE_UTILITY_SCRIPTS_DIR:
    win: "{PROGRAMDATA}/Blackmagic Design/DaVinci Resolve/Fusion/Scripts/Comp"
    darwin: /Library/Application Support/Blackmagic Design/DaVinci Resolve/Fusion/Scripts/Comp
    linux: /opt/resolve/Fusion/Scripts/Comp

[BigRoy]

However while revieing I started wondering whether it might be more flexible to allow users to define RESOLVE_SCRIPT_API, RESOLVE_SCRIPT_LIB, and RESOLVE_UTILITY_SCRIPTS_DIR directly instead introducing a new variable.

I'm not sure how often it may be the case these vary from the actual resolve root - if it doesn't then I think RESOLVE_ROOT is sufficient if all the others are constant relatively to it, per platform.