Implement getting cobalt startup time for 3P platforms #8488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
niranjanyardi
force-pushed
the
performance_api_1
branch
from
62f566d to
eb6f5b9
Compare
niranjanyardi
force-pushed
the
performance_api_1
branch
from
eb6f5b9 to
9f18ae9
Compare
niranjanyardi
force-pushed
the
performance_api_1
branch
from
9f18ae9 to
d916d62
Compare
niranjanyardi
commented
Dec 29, 2025
| int64_t time_origin = performance_obj.GetTimeOriginInternal().ToInternalValue(); | ||
| LOG(INFO) << "OriginTime is "<< time_origin; | ||
| LOG(INFO) << "startup_time variable value is "<< startup_time; | ||
| double startup_time_ms = static_cast<double>(startup_time - time_origin) / 1000.0; |
Contributor
Author
There was a problem hiding this comment.
let's discuss in tomnorow's meeting @andrewsavage1
want to double check with you if this looks okay or you had something else in mind
| } // namespace | ||
|
|
||
| void SetStartupTime(int64_t startup_time) { | ||
| g_startup_time = startup_time; |
Contributor
There was a problem hiding this comment.
Don't you need a mutex guarding access to this?
| BindRemotePerformance(script_state)->GetAppStartupTime(&startup_time); | ||
| ScriptPromise promise = resolver->Promise(); | ||
| #if BUILDFLAG(IS_STARBOARD) | ||
| int64_t time_origin = performance_obj.GetTimeOriginInternal().ToInternalValue(); |
Contributor
There was a problem hiding this comment.
Instead of converting this to an int64_t, which is not an intuitive type, let's convert startup_time to a base::Time to make the math we're doing more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.