-
Notifications
You must be signed in to change notification settings - Fork 175
[DNS] Enable cobalt_browsertests on Linux with is_starboard=True #8490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables cobalt_browsertests on Linux with Starboard, which is a valuable addition. The changes are mostly correct and follow the right direction by updating build files, test configurations, and adding a new main entry point for Starboard. However, I've identified a few areas for improvement. There's a leftover debug log, some code hygiene issues like an unused include and duplicated includes, a potential correctness issue with a missing override specifier, and a memory leak in the new test runner. Addressing these points will enhance the code's quality and maintainability.
Enable cobalt_browsertests on Linux with starboard.
Also plumbed ContentMainRunnerImplBrowserTest as a demo.
Test:
Issue: 433354983