Skip to content

Conversation

@isarkis
Copy link
Member

@isarkis isarkis commented Dec 20, 2025

Unit test jobs in CI occasionally time out, even when tests
are configured to retry. The existing job timeout of 2100
seconds does not provide sufficient time for a second attempt
to complete after an initial test timeout of 1800 seconds.
Increase the default job timeout to 2700 seconds to give a
subsequent test attempts a fighting chance.

Issue: 470590965

Occasionally, unit test job timing out because they time out after first attempt (test time out set to 1800 seconds) and it doesn't give enough time for second attempt to succeed.

Issue: 470590965
@isarkis isarkis requested a review from oxve December 20, 2025 17:17
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


ci: Increase unit test job timeout

Unit test jobs in CI occasionally time out, even when tests
are configured to retry. The existing job timeout of 2100
seconds does not provide sufficient time for a second attempt
to complete after an initial test timeout of 1800 seconds.
Increase the default job timeout to 2700 seconds to ensure
there is enough time for subsequent test attempts to finish.

Bug: 470590965

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@isarkis isarkis requested review from arjungm and cvinish December 20, 2025 17:17
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the default job timeout for on-device tests to prevent CI failures. The change is simple, but I have two suggestions for improvement. First, the argument type for the timeout should be int instead of str for better type safety. Second, the new timeout value of 2700 seconds may still be insufficient to cover two full test attempts, which could take up to 3600 seconds plus startup time. A more robust timeout value would prevent this issue from recurring.

Comment on lines +354 to 356
default='2700',
help='Timeout in seconds for the job. Must be set higher and '
'start_timeout_sec and test_timeout_sec combined.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The new timeout of 2700 seconds might not be sufficient. According to the PR description, this change is to allow a second test attempt to succeed. With test_timeout_sec at 1800 seconds, two attempts could take up to 3600 seconds, plus any startup time (start_timeout_sec). The current value of 2700s doesn't cover this worst-case scenario and may lead to timeouts in the future. The job timeout should be set to a value that can reliably accommodate all attempts, for instance by following a formula like (number_of_attempts * test_timeout_sec) + start_timeout_sec.

Comment on lines 353 to +354
type=str,
default='2100',
default='2700',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a numeric timeout value, it's better practice to use type=int instead of type=str. This ensures the value is parsed correctly as an integer at the command-line level, preventing potential bugs and simplifying the code that uses this value, as it won't need to perform its own type conversion.

Suggested change
type=str,
default='2100',
default='2700',
type=int,
default=2700,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants