-
Notifications
You must be signed in to change notification settings - Fork 175
Clean up use of android.util.Log in //cobalt. #8516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a7dbb04 to
df9d9dc
Compare
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces usages of android.util.Log with org.chromium.base.Log across several files, which aligns with the goal of centralizing logging through the Chromium base library. The changes are mostly straightforward replacements of imports and method calls.
I've added a couple of suggestions for dev.cobalt.util.Log to further refactor the class by removing redundant logic and reflection, now that it's backed by org.chromium.base.Log which provides similar functionality natively. This would improve code clarity and maintainability.
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaDrmBridge.java
Outdated
Show resolved
Hide resolved
Awallky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments.
Thanks so much for doing this!
1d0f4d6 to
5a37a80
Compare
Move usage of android.util.Log to org.chromium.base.Log. The new Log class proxies the original Log methods with additional functionality tacked on. Bug: 472345388 Change-Id: I68d664dfa7bf6a0c2c78d0bfeb841aadc3302af9
5a37a80 to
e2b6885
Compare
Move usage of android.util.Log to org.chromium.base.Log. The new Log class proxies the original Log methods with additional functionality tacked on.
Bug: 472345388