Skip to content

Conversation

@SortaCookie
Copy link
Contributor

Move usage of android.util.Log to org.chromium.base.Log. The new Log class proxies the original Log methods with additional functionality tacked on.

Bug: 472345388

@SortaCookie SortaCookie requested a review from Awallky December 30, 2025 19:36
@SortaCookie SortaCookie requested a review from a team as a code owner December 30, 2025 19:36
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


android: Move to org.chromium.base.Log

Migrate all direct usages of android.util.Log in Cobalt's Android
Java code to org.chromium.base.Log. This change standardizes logging
practices across the application. The org.chromium.base.Log class
provides additional functionality and a consistent logging interface
for the Chromium codebase, from which Cobalt is forked.

Bug: 472345388

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces usages of android.util.Log with org.chromium.base.Log across several files, which aligns with the goal of centralizing logging through the Chromium base library. The changes are mostly straightforward replacements of imports and method calls.

I've added a couple of suggestions for dev.cobalt.util.Log to further refactor the class by removing redundant logic and reflection, now that it's backed by org.chromium.base.Log which provides similar functionality natively. This would improve code clarity and maintainability.

Copy link
Contributor

@Awallky Awallky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.
Thanks so much for doing this!

@SortaCookie SortaCookie force-pushed the fix/log-cleanup branch 3 times, most recently from 1d0f4d6 to 5a37a80 Compare December 30, 2025 20:53
Move usage of android.util.Log to org.chromium.base.Log. The new Log
class proxies the original Log methods with additional functionality
tacked on.

Bug: 472345388
Change-Id: I68d664dfa7bf6a0c2c78d0bfeb841aadc3302af9
@SortaCookie SortaCookie enabled auto-merge (squash) January 2, 2026 16:25
@SortaCookie SortaCookie added the cp-26.android Cherry Pick to the 26.android branch label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp-26.android Cherry Pick to the 26.android branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants