RFC: simplify callbacks implementation #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
rfc_analysis_cb
branch
from
89287a4 to
c3d5767
Compare
neutrinoceros
force-pushed
the
rfc_analysis_cb
branch
from
c3d5767 to
c0d5b2a
Compare
neutrinoceros
changed the title
Member
Author
|
The error on circle CI is unrelated and likely temporary. I'll open a ticket if it persists later today. |
brittonsmith
approved these changes
Oct 19, 2023
Member
brittonsmith
left a comment
brittonsmith
left a comment
There was a problem hiding this comment.
All good with me. Not sure why we ever did it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small but unrelated simplification I found while working on #229